Von: Alexander Barton <alex@barton.de>
Datum: 11. November 2008 18:14:57 MEZ
An: ircservices@ircservices.za.net
Betreff: [IRCServices] Patch: Flush write buffer on connect
Antwort an: IRC Services General Mailing List <ircservices@ircservices.za.net>
X-Mailer: Apple Mail (2.929.2)

Hi!

The attached patch fixes the problem that IRCServices don't flush the  
write buffer when the connection to the server is establised and data  
has already been written to the buffer.

This caused the server to disconnect IRCServices after a timeout  
because of no data has been sent. Solution has been to send  
IRCServices a HUP signal right after starting it. I was able to  
reproduce this problem on all of my machines (Linux on HPPA, Linux on  
amd64, and Mac OS X on i386).

I think these messages describe the same problem:
<http://lists.ircservices.za.net/pipermail/ircservices/2007/005283.html>
<http://lists.ircservices.za.net/pipermail/ircservices/2007/005288.html>
<http://lists.ircservices.za.net/pipermail/ircservices/2007/005318.html>
<http://lists.ircservices.za.net/pipermail/ircservices/2007/005319.html>
<http://lists.ircservices.za.net/pipermail/ircservices/2007/005287.html>

Regards
Alex


diff -rup ircservices-5.1.13-orig/sockets.c ircservices-5.1.13/sockets.c
--- ircservices-5.1.13-orig/sockets.c	2008-11-07 18:11:57.000000000 +0100
+++ ircservices-5.1.13/sockets.c	2008-11-09 15:53:35.000000000 +0100
@@ -691,6 +691,10 @@ void check_sockets(void)
                }
                s->flags &= ~SF_CONNECTING;
                s->flags |= SF_CONNECTED;
+
+		/* Flush already cached data for this socket */
+		flush_write_buffer(s);
+
                FD_CLR(i, &write_fds);
                if (!(s->flags & SF_MUTE))
                    FD_SET(i, &sock_fds);